fix: wrong desc setting cont_batching #6034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to b709c6b in 46 seconds. Click for details.
- Reviewed
47lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/llamacpp-extension/settings.json:156
- Draft comment:
The updated 'cont_batching' description is clear and now omits the confusing default mention. This resolves the issue as described. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/hooks/useModelProvider.ts:216
- Draft comment:
The migration function properly updates the 'cont_batching' setting's description for persisted state. For future maintainability, consider extracting the description string into a shared constant to avoid duplication. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_w0pq4azw3Yuilx9f
You can customize 
Contributor
Barecheck - Code coverage reportTotal: 38.75%Your code coverage diff: -0.01% ▾ |
louis-jan
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes a minor update to the description of the
cont_batchingsetting and introduces a migration to ensure the updated description is applied to persisted state in the application.Updates to
cont_batchingsetting:extensions/llamacpp-extension/settings.json: Simplified the description of thecont_batchingsetting by removing the mention of the default state.State migration for updated description:
web-app/src/hooks/useModelProvider.ts: Added a migration function to update thecont_batchingdescription in persisted state forllamacppproviders. This ensures consistency across application versions.Fixes Issues
Self Checklist
Important
Simplifies
cont_batchingdescription and adds migration to update persisted state forllamacppproviders.cont_batchingdescription insettings.jsonby removing default state mention.useModelProvider.tsto updatecont_batchingdescription in persisted state forllamacppproviders.This description was created by
for b709c6b. You can customize this summary. It will automatically update as commits are pushed.